-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation about rfc2136 TTLs #1581
Conversation
Now that `--rfc2136-min-ttl` is an option, show how to set it and also how to override it using an annotation.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @stefanlasiewski! |
@stefanlasiewski Could you accept CLA? |
I need to get approval before I can sign the agreement, and I hope that will happen soon. |
I think you have a typo in the name of the MR, |
Just FYI, I am still waiting for approval. |
Thank you for catching that. Fixed. |
@stefanlasiewski any luck getting the CLA signed? |
No, not yet, unfortunately. |
@stefanlasiewski let me know if there is anything I can do to assist with this. Thanks! |
I signed it |
/lgtm |
/kind documentation |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, stefanlasiewski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now that
--rfc2136-min-ttl
is an option, show how to set it and also how to override it using an annotation.