-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
digitalocean: increase API page size #1611
digitalocean: increase API page size #1611
Conversation
/assign @njuettner |
@tdyas thank you for your PR! Would you be able to tell me what are the consequences in terms of usage of the API or performance to increase such value? Wouldn't it be better to make it configurable via a flag or is it generally safe to have 200 as default? |
I used 200 mainly because it is used in the DigitalOcean Terraform provider (see https://github.com/terraform-providers/terraform-provider-digitalocean/blob/fd9e7b8b8156599799c7b2e636f68a529929b3bf/digitalocean/datasource_digitalocean_sizes.go#L88 for an example), and is one order of magnitude up from the default of 20. I'd be fine with making it configurable though. My external-dns deployment is not at the scale where I would be able to see it make it difference or not. Thus making it configurable would allow people with deployments at that scale to tune it to their needs. |
@tdyas as Raffo said please make it configurable 🙂. People like to like at the options of their preferred provider. The less hardcoded stuff we have the better it is for us to maintain it. |
6e1e5cb
to
51fd8a9
Compare
Makes sense. The latest commits make it configurable via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, tdyas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The default API page size for the DigitalOcean API is 20 objects. Increase to 200 to reduce the number of API calls required to enumerate domains and records. Should fix #1429.