Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OVH API rate limiting option (Fix #1546) #1619

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add OVH API rate limiting option (Fix #1546) #1619

merged 1 commit into from
Jun 17, 2020

Conversation

Hugome
Copy link
Contributor

@Hugome Hugome commented Jun 7, 2020

Currently the "rate-limiting" is controlled by the GOMAXPROCS, and if you have a lot of threads you will explode the rate limit of the OVH api (As of #1546).
This add a simple rate-limiting implmentation and should fix #1546

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from linki and Raffo June 7, 2020 03:06
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jun 7, 2020
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, can you rebase from master and run make lint. It might complain because of unnecessary empty lines. I just want to make it ok.

pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
@Hugome
Copy link
Contributor Author

Hugome commented Jun 9, 2020

Rebase done (Seem OK), I can remove empty line manually if you prefer ?

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hugome, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit c0dfaed into kubernetes-sigs:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVH provider : communication with eu.api.ovh.com
3 participants