-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OVH API rate limiting option (Fix #1546) #1619
Add OVH API rate limiting option (Fix #1546) #1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, can you rebase from master and run make lint
. It might complain because of unnecessary empty lines. I just want to make it ok.
Rebase done (Seem OK), I can remove empty line manually if you prefer ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Hugome, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the "rate-limiting" is controlled by the GOMAXPROCS, and if you have a lot of threads you will explode the rate limit of the OVH api (As of #1546).
This add a simple rate-limiting implmentation and should fix #1546