Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore wildcard hosts in Istio gateways #1625

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Ignore wildcard hosts in Istio gateways #1625

merged 2 commits into from
Aug 18, 2020

Conversation

haines
Copy link
Contributor

@haines haines commented Jun 11, 2020 •
edited

Fixes #1518
Fixes #1624

Istio allows * or namespace/* as Gateway hosts, meaning that it selects all VirtualService hosts from the specified namespace (or all namespaces if none is specified).

This PR skips such hosts to avoid attempting to create DNS records for * (as described in the linked issue this currently causes external-dns to crash).

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @haines!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2020
@haines
Copy link
Contributor Author

haines commented Jun 11, 2020

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 11, 2020
@haines
Copy link
Contributor Author

haines commented Jun 11, 2020

/assign @hjacobs

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2020
@haines
Copy link
Contributor Author

haines commented Jun 16, 2020

/assign @Raffo

@elsesiy
Copy link
Contributor

elsesiy commented Jun 17, 2020

This might solve #1518 as well

@mikefaille
Copy link

mikefaille commented Jul 13, 2020 •
edited

I got the same issues like <all mentioned above>. I rebased locally, I tested and it fixed them. Please merge once we check the logic and the style.

@haines haines force-pushed the ignore-wildcard-hosts-in-istio-gateways branch from ec2fc15 to d69d191 Compare July 14, 2020 08:23
@haines
Copy link
Contributor Author

haines commented Jul 14, 2020

I've rebased to bring this branch up to date - @Raffo, are you able to review this please?

@mikefaille
Copy link

@njuettner seems to be able to approve commits on this project too.

@njuettner Please, if you are available, could you review this commit too ? Thank you a lot.

@jessebye
Copy link

This is a blocker for us. How can we get this merged?

@mikefaille
Copy link

cc : @kbhandari

tariq1890
tariq1890 reviewed Aug 13, 2020
View reviewed changes
source/gateway.go
@@ -300,9 +295,16 @@ func (sc *gatewaySource) hostNamesFromGateway(gateway networkingv1alpha3.Gateway
host = parts[1]
}

hostnames = append(hostnames, host)
if host != "*" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you club this check with if host == "" { in L286?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - my-namespace/* is a valid option for the host, so we need to check for * after stripping the namespace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes makes sense :)

@tariq1890
Copy link
Contributor

@haines Thanks for fixing this. LGTM; just a minor comment

@tariq1890
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@tariq1890
Copy link
Contributor

@njuettner @Raffo This code LGTM. Can we get this merged and have a patch release out for this?

njuettner
njuettner approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haines, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8bef375 into kubernetes-sigs:master Aug 18, 2020
@haines haines deleted the ignore-wildcard-hosts-in-istio-gateways branch August 18, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@tariq1890 tariq1890 tariq1890 approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

@njuettner njuettner

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
9 participants
@haines @k8s-ci-robot @elsesiy @mikefaille @jessebye @tariq1890 @njuettner @hjacobs @Raffo