-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UltraDNS Provider #1635
UltraDNS Provider #1635
Conversation
Feature/ultradns provider
Welcome @kbhandari! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
Made changes according to the new external-dns changes
Added golints recommendations
/assign @Raffo |
Incorporated review comments
/assign @njuettner |
Thanks @njuettner for your feedback! |
Incorporated Review comments
/assign @njuettner |
@njuettner kindly review and approve. |
@kbhandari do you mind solving the conflicts and add your PR into the ChANGELOG.md, then I can merge it |
@njuettner I have resolved the conflicts and added my PR in the CHANGELOG.md, kindly merge. Thanks! |
/assign @njuettner |
@njuettner I have resolved the conflicts and added my PR in the CHANGELOG.md, kindly merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhandari, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Greetings!
Thought it might be good to integrate UltraDNS Provider with external-dns. Let me know if there are any changes that may need to be made with the PR!