Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scaleway DNS as a new provider #1643

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Add Scaleway DNS as a new provider #1643

merged 6 commits into from
Aug 19, 2020

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Jun 23, 2020

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from linki and Raffo June 23, 2020 17:39
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jun 23, 2020

/assign @njuettner

@linki
Copy link
Member

linki commented Jul 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@linki
Copy link
Member

linki commented Jul 1, 2020

Let's also add an entry in the CHANGELOG.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jul 1, 2020

@linki done!

jerome-quere
jerome-quere reviewed Jul 7, 2020
View reviewed changes
provider/scaleway/scaleway.go Outdated Show resolved Hide resolved
provider/scaleway/scaleway.go Outdated Show resolved Hide resolved
provider/scaleway/scaleway.go Outdated Show resolved Hide resolved
njuettner
njuettner approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise lgtm

docs/tutorials/scaleway.md Outdated Show resolved Hide resolved
provider/scaleway/scaleway.go Show resolved Hide resolved
@Raffo Raffo unassigned linki Jul 8, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jul 20, 2020

@njuettner Can it be merged?

@njuettner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@njuettner
Copy link
Member

@Sh4d1 do you mind solving the conflicts and then I can merge it

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jul 29, 2020

@njuettner done 😄

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Aug 7, 2020

@njuettner just missed the release 😅 could it be merged before next one?

@seanmalloy
Copy link
Member

/kind feature

@Sh4d1 please fix the merge conflicts. Thanks!

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2020
Sh4d1 and others added 6 commits August 19, 2020 06:41
@Sh4d1
Add Scaleway DNS as a new provider
9a7a873 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
fix scw annotations
b1f6c1f 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
clean unused code
c0b913a 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
Add changelog entry
e18d75c 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
fix review
b090169 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1 @njuettner
Update docs/tutorials/scaleway.md
b22edb8 
Co-authored-by: Nick Jüttner <nick@juni.io>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Aug 19, 2020

@seanmalloy ✔️

njuettner
njuettner approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit a763d15 into kubernetes-sigs:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere left review comments

@njuettner njuettner njuettner approved these changes

@linki linki Awaiting requested review from linki

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sh4d1 @linki @njuettner @seanmalloy @k8s-ci-robot @jerome-quere