Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally ignore tls rules in ingress source #1645

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Optionally ignore tls rules in ingress source #1645

merged 1 commit into from
Sep 24, 2020

Conversation

Benjile
Copy link
Contributor

@Benjile Benjile commented Jun 24, 2020 •
edited

Add a flag to ignore ingress tls section during endpoints discovery

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2020
@Benjile Benjile force-pushed the ignore_tls_rules branch 2 times, most recently from 1fc6e17 to 413db36 Compare June 24, 2020 14:26
@Benjile Benjile closed this Jun 24, 2020
@Benjile Benjile reopened this Jun 24, 2020
@Benjile Benjile closed this Jun 24, 2020
@Benjile Benjile reopened this Jun 24, 2020
@Benjile Benjile closed this Jun 24, 2020
@Benjile Benjile reopened this Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 24, 2020
@Benjile
Copy link
Contributor Author

Benjile commented Jun 24, 2020

fixes #1220

@Benjile
Copy link
Contributor Author

Benjile commented Jun 24, 2020

/assign @linki

@Benjile
Copy link
Contributor Author

Benjile commented Jun 29, 2020 •
edited

The footprint of this PR is very light. Moreover it is designed to not break configurations already deployed. It just offers a way to disable host entries discovery via tls section which was introduced one year ago and which suffers of many problems (wildcards and blackholes for example).

Is there something i can do for this PR being approved and merged?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2020
@Benjile Benjile force-pushed the ignore_tls_rules branch 3 times, most recently from bd45653 to 8884579 Compare July 16, 2020 10:38
@Benjile
Copy link
Contributor Author

Benjile commented Jul 17, 2020 •
edited

hello
I do not understand what is happening here.

make cover-html shows me the code is covered by tests but for the coverall web service it is not.

@Benjile
Copy link
Contributor Author

Benjile commented Jul 21, 2020

/assign @Raffo

Sorry to change the assignee but it seems @linki is not available

@seanmalloy
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2020
@Benjile
Copy link
Contributor Author

Benjile commented Aug 19, 2020

/assign @njuettner

Please let me know what i can do to get this merged.

tariq1890
tariq1890 reviewed Aug 21, 2020
View reviewed changes
coverage.out Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Aug 21, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
@Benjile Benjile force-pushed the ignore_tls_rules branch 2 times, most recently from a59a9d0 to 2a9a81f Compare August 21, 2020 21:41
@seanmalloy
Copy link
Member

/assign

@seanmalloy
Copy link
Member

@Benjile I've started to review this PR. It looks good so far. I just have two more files to review.

@Benjile
Copy link
Contributor Author

Benjile commented Sep 17, 2020

@Benjile I've started to review this PR. It looks good so far. I just have two more files to review.

great
thank you @seanmalloy

@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo @njuettner
/cc @tariq1890

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
@Raffo
Copy link
Contributor

Raffo commented Sep 24, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjile, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@Raffo Raffo linked an issue Sep 24, 2020 that may be closed by this pull request
esp. for wildcard certificates, how to disable discovery from tls.hosts? #1220
Closed
@k8s-ci-robot k8s-ci-robot merged commit 32fedea into kubernetes-sigs:master Sep 24, 2020
@Benjile
Copy link
Contributor Author

Benjile commented Sep 24, 2020

thank you @Raffo @tariq1890 @seanmalloy

@dansimone dansimone mentioned this pull request Sep 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@hjacobs hjacobs Awaiting requested review from hjacobs

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@linki linki

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esp. for wildcard certificates, how to disable discovery from tls.hosts?
7 participants
@Benjile @k8s-ci-robot @seanmalloy @Raffo @tariq1890 @linki @njuettner