Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apiVersions in docs #1690

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Update apiVersions in docs #1690

merged 2 commits into from
Aug 5, 2020

Conversation

ddgenome
Copy link
Contributor

@ddgenome ddgenome commented Jul 28, 2020 •
edited
Loading

Update docs to reflect new apiVersions for ingresses and deployments.

Checklist

  • Update changelog in CHANGELOG.md, use section "Unreleased".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ddgenome!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2020
@linki
Copy link
Member

linki commented Jul 28, 2020

@ddgenome Thanks a lot! Please see my comment regarding the matchLabels field on apps/v1 Deployments.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2020
@ddgenome ddgenome requested a review from linki July 28, 2020 19:03
@ddgenome
Copy link
Contributor Author

@linki I've made your requested changes.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@ddgenome
Update apiVersions in docs
3dba401 
Update docs to reflect new apiVersions for ingresses and deployments.
@ddgenome
Add selector to apps/v1 deployments
5f2c9bd
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2020
@Raffo Raffo added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 5, 2020
@Raffo
Copy link
Contributor

Raffo commented Aug 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddgenome, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit cd750c9 into kubernetes-sigs:master Aug 5, 2020
@ddgenome ddgenome deleted the docs-api-versions branch August 5, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjacobs hjacobs Awaiting requested review from hjacobs

@Raffo Raffo Awaiting requested review from Raffo

@linki linki Awaiting requested review from linki

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddgenome @k8s-ci-robot @linki @Raffo