aws: errors with context #1705
Merged
aws: errors with context #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bpineau
force-pushed
the
aws-errors-context
branch
3 times, most recently
from
11af9fa
to
6f1bf45
Compare
k8s-ci-robot
added
the
needs-rebase
bpineau
force-pushed
the
aws-errors-context
branch
from
6f1bf45
to
83c2323
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I see that files |
seanmalloy
reviewed
Aug 13, 2020
provider/aws/aws.go
Outdated
| @@ -166,7 +167,7 @@ func NewAWSProvider(awsConfig AWSConfig) (*AWSProvider, error) { | |||
| SharedConfigState: session.SharedConfigEnable, | |||
| }) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, errors.Wrap(err, "failed to instantiate AWS session") | |||
There was a problem hiding this comment.
Maybe ...
return nil, fmt.Errorf("failed to instantiate AWS session: %w", err)See https://blog.golang.org/go1.13-errors for reference.
There was a problem hiding this comment.
Yes, I hesitated to introduce a dep to a Go version; but just checked the CI and Dockerfile are using 1.14 so I assume we're good with go >= 1.13. Updated.
When faced with errors from cloud providers (like "Throttling: Rate exceeded"), it's not always easy to find what operation caused the failure, and what action was aborted, if any, Let's make it easier to identify an error source (and affected object when possible) by providing more context (and by using easy to find error messages).
bpineau
force-pushed
the
aws-errors-context
branch
from
83c2323
to
b64e3ac
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
seanmalloy
approved these changes
Aug 16, 2020
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpineau, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When faced with errors from cloud providers (like "Throttling: Rate exceeded"), it's not always easy to find what operation caused the failure, and what action was aborted, if any.
Let's make it easier to identify an error source (and affected object when possible) on AWS by providing more context (and by using easy to find error messages).
Checklist