Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --txt-prefix to google deployment #1729

Merged
merged 2 commits into from
Aug 20, 2020
Merged

added --txt-prefix to google deployment #1729

merged 2 commits into from
Aug 20, 2020

Conversation

prune998
Copy link
Contributor

@prune998 prune998 commented Aug 18, 2020 •
edited

when using registry=txt option, make sure to also use the txt-prefix and txt-owner-id options as well. If you try to create a TXT record without a prefix, it will try to create a TXT record with the same name as your actual DNS record and fail (creating a stranded record external-dns cannot manage).

Checklist

  • Update changelog in CHANGELOG.md, use section "Unreleased".

@prune998
added --txt-prefix to google deployment
e0723bb 
when using `registry=txt` option, make sure to also use the `txt-prefix` and `txt-owner-id` options as well. If you try to create a `TXT` record in VinylDNS without a prefix, it will try to create a `TXT` record with the same name as your actual DNS record and fail (creating a stranded record `external-dns` cannot manage).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @prune998!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@prune998 prune998 mentioned this pull request Aug 18, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2020
@prune998
Copy link
Contributor Author

/assign @linki

@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo @njuettner
/unassign @linki

@k8s-ci-robot k8s-ci-robot assigned njuettner, Raffo and seanmalloy and unassigned linki Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@seanmalloy
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 18, 2020
@jgrumboe
Copy link
Contributor

Don't know how VinylDNS is doing sorting/display of DNS records in management console, but probably the usage of --txt-suffix is better than --txt-prefix. So the TXT records should be sorted alphabetically directly after the corresponding A or CNAME record.

@seanmalloy
Copy link
Member

but probably the usage of --txt-suffix is better than --txt-prefix.

@prune998 would you be able to confirm that the --txt-suffix option works for you and update the docs accordingly?

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@prune998
Copy link
Contributor Author

Don't know how VinylDNS is doing sorting/display of DNS records in management console, but probably the usage of --txt-suffix is better than --txt-prefix. So the TXT records should be sorted alphabetically directly after the corresponding A or CNAME record.

This is the doc for Google (Google Cloud DNS), not VinylDNS...

@seanmalloy I don't have access to any GKE / Google cloud for now (transitioning job)... Can't test right now.

@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@jgrumboe
Copy link
Contributor

jgrumboe commented Aug 18, 2020 •
edited

@prune998

This is the doc for Google (Google Cloud DNS), not VinylDNS...

Sorry, you wrote VinylDNS in your first comment and also within your code comments, so I thought it is about that. 😄

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@prune998
Copy link
Contributor Author

@prune998

This is the doc for Google (Google Cloud DNS), not VinylDNS...

Sorry, you wrote VinylDNS in your first comment and also within your code comments, so I thought it is about that. 😄

You're totally right. I removed it and pushed again. The comment is coming from the VinylDNS doc as it works the same way...
Thanks for spotting it !

@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
vinny-sabatini
vinny-sabatini approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@vinny-sabatini vinny-sabatini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

njuettner
njuettner approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, prune998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8b3ec72 into kubernetes-sigs:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy seanmalloy approved these changes

@njuettner njuettner njuettner approved these changes

@vinny-sabatini vinny-sabatini vinny-sabatini approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@linki linki Awaiting requested review from linki

Assignees

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@prune998 @k8s-ci-robot @seanmalloy @jgrumboe @njuettner @vinny-sabatini @linki @Raffo