-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add license header check to the CI #1738
Conversation
FYI ... @vinny-sabatini this is a simple PR that you could review. |
@tariq1890: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tariq1890: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me.
The only improvement I can think of is moving the golangci-lint
into its own Make target, and then having the lint
target run both the license check and the go lint check.
I believe this PR is doing exactly just that |
I believe this adds a new |
Oh got it. Yea, that makes sense. |
c28e3a3
to
6ec6e3d
Compare
@vinny-sabatini I've addressed your comments. Thanks for the review! |
/lgtm @tariq1890 thanks for your contribution! @vinny-sabatini thanks for your detailed review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Checklist