Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: enhance pull request template #1747

Merged
merged 2 commits into from
Aug 26, 2020
Merged

docs: enhance pull request template #1747

merged 2 commits into from
Aug 26, 2020

Conversation

seanmalloy
Copy link
Member

@seanmalloy seanmalloy commented Aug 24, 2020 •
edited

  • Added unit tests to the checklist
  • Added end user docs to the checklist
  • Added link to the contributing docs
  • Added section for description and issue links

Checklist

  • Update changelog in CHANGELOG.md, use section "Unreleased".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2020
@seanmalloy
Copy link
Member Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 24, 2020
@seanmalloy
Copy link
Member Author

@tariq1890 and @vinny-sabatini this is pull request round two of documentation updates. Please take a look when you have some time. Thanks!

@seanmalloy
Copy link
Member Author

/assign @Raffo @njuettner

tariq1890
tariq1890 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2020
@Raffo
Copy link
Contributor

Raffo commented Aug 26, 2020

@seanmalloy Thank you this is really helpful! Can you please resolve the conflicts? Happy to approve after that.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2020
@seanmalloy
docs: enhance pull request template
c97f7ee 
* Added unit tests to the checklist
* Added end user docs to the checklist
* Added link to the contributing docs
* Added section for description and issue links
@seanmalloy
Bump CHANGELOG
6ffb6dc
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 26, 2020
@seanmalloy
Copy link
Member Author

@Raffo and @njuettner rebased and merge conflict fixed. Please take a look when you have some time. Thanks!

@Raffo
Copy link
Contributor

Raffo commented Aug 26, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 275f2e6 into kubernetes-sigs:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@vinny-sabatini vinny-sabatini vinny-sabatini approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@linki linki Awaiting requested review from linki

Assignees

@Raffo Raffo

@njuettner njuettner

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seanmalloy @Raffo @k8s-ci-robot @tariq1890 @vinny-sabatini @njuettner