Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilize the errors package for error handling #1748

Merged
merged 1 commit into from
Aug 26, 2020
Merged

utilize the errors package for error handling #1748

merged 1 commit into from
Aug 26, 2020

Conversation

vinny-sabatini
Copy link
Contributor

Checklist

  • Update changelog in CHANGELOG.md, use section "Unreleased".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2020
@vinny-sabatini vinny-sabatini mentioned this pull request Aug 25, 2020
Closed
1 task
@vinny-sabatini
Copy link
Contributor Author

I did not update the CHANGELOG.md in this PR because I believe this change is covered in the line Improve errors context for AWS provider. Let me know if we still want a separate entry for this change.

@seanmalloy
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 25, 2020
@seanmalloy
Copy link
Member

/lgtm
/assign @tariq1890

@tariq1890 please review this when you have some time. If you think this looks good then we will assign this to the external-dns maintainers for final review and approval. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2020
@tariq1890
Copy link
Contributor

Thanks @vinny-sabatini :). The code LGTM

@seanmalloy
Copy link
Member

/assign @Raffo @njuettner

@tariq1890
Copy link
Contributor

/lgtm

njuettner
njuettner approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, vinny-sabatini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit c12b269 into kubernetes-sigs:master Aug 26, 2020
@seanmalloy seanmalloy deleted the aws-error-handling branch August 26, 2020 12:54
@vinny-sabatini vinny-sabatini mentioned this pull request Sep 3, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy seanmalloy approved these changes

@njuettner njuettner njuettner approved these changes

@tariq1890 tariq1890 tariq1890 approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vinny-sabatini @seanmalloy @tariq1890 @k8s-ci-robot @njuettner @Raffo