Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for GKE with workload identity #1765

Merged

Conversation

ddgenome
Copy link
Contributor

@ddgenome ddgenome commented Aug 31, 2020

Description

Add instructions for using GKE workload identity to allow ExternalDNS
to authenticate against Google Cloud DNS APIs. Use modern Docker
images. Add blog link to README.

Signed-off-by: David Dooling dooling@gmail.com

Checklist

  • Unit tests updated
  • End user documentation updated
  • CHANGELOG.md updated, use section "Unreleased"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2020
@seanmalloy
Copy link
Member

@ddgenome can you fix the merge conflict in file docs/tutorials/nginx-ingress.md?

/assign

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2020
@ddgenome
Copy link
Contributor Author

@seanmalloy done

@ddgenome
Copy link
Contributor Author

@seanmalloy this is in response to your request here https://kubernetes.slack.com/archives/C771MKDKQ/p1597766119191400?thread_ts=1597745735.188200&cid=C771MKDKQ

Add instructions for using GKE workload identity to allow ExternalDNS
to authenticate against Google Cloud DNS APIs. Add blog link to
README.

Signed-off-by: David Dooling <dooling@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2020
@seanmalloy
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 1, 2020
@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo @njuettner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddgenome, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9b923e9 into kubernetes-sigs:master Sep 1, 2020
@ddgenome ddgenome deleted the gke-workload-identity branch September 1, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants