Adds release script #1794
Merged
Adds release script #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Please review @njuettner |
Raffo
added
the
tide/merge-method-squash
|
@Raffo |
1 task
|
@jgrumboe No, I was actually thinking of getting rid of the changelog file and only use releases. We don't have the requirements that kubernetes/kubernetes has of putting together changes from multiple repos, so the changelog file isn't super useful as of today. If the community feels strongly about having a changelog file, I'm open to reconsidering this. |
|
Adding a hold, so @njuettner can do a review. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
njuettner
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgroschupp
pushed a commit
to cgroschupp/external-dns
that referenced
this pull request
Mar 23, 2021
* adds release script Signed-off-by: Raffaele Di Fazio <raffo@github.com> * save Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com> * scripts Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com> * update script Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com> * update docs Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com> * Update releaser.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1754 .
This is largely the same script from https://github.com/cli/cli/blob/trunk/script/changelog, requires
ghto be run as well. It generates a release note compliant to what we have been using in ExternalDNS till today.The scripts must be run manually by whoever has permissions to create releases. My initial idea was to use GitHub actions today by leveraging a manually triggered workflow, but actions does not support limiting who can run workflows to specific users or groups. This means that any user with write access could potentially make a release and that's clearly not ideal. I'll wait building the automation for that for when actions will support any functionality that will allow us to limit who can do releases.
This PR also updates the documentation for the release process.