Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nektos/act #1802

Merged

Conversation

jgrumboe
Copy link
Contributor

@jgrumboe jgrumboe commented Oct 2, 2020

Description

This PR adds support for nektos/act to run github actions locally.

Checklist

  • End user documentation updated

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 2, 2020

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 2, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 2, 2020

@vinny-sabatini could you please review

@Raffo
Copy link
Contributor

Raffo commented Oct 2, 2020

@jgrumboe I haven't used nektos/act myself, so I don't really have an opinion on that, but I do have a question: given that in CI we basically just run builds and tests, which are cross platform and can be natively run locally, what is the benefit of being able to run those locally?

@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 2, 2020

@Raffo It gives you the possibility to test the usage of github actions before committing and waiting for failed or successful CI runs.

And it is convenient for me to just run "act" and the CI pipeline kicksoff like after git push.

@Raffo
Copy link
Contributor

Raffo commented Oct 2, 2020

@jgrumboe "it's convenient" is good enough for me. I will approve once you get a LGTM. One thing I don't understand: why is there no check for actions in this PR?

@seanmalloy
Copy link
Member

One thing I don't understand: why is there no check for actions in this PR?

We need to figure this out before it can be merged. Other recent pull requests have the GH actions running. Does this change somehow prevent/break the GH actions?

@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 2, 2020

Found the error: invalid syntax
https://github.com/kubernetes-sigs/external-dns/actions/runs/283763068
🤦‍♂️
Will look into it the next days.

@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 2, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 3, 2020

/unhold

The if: expression needs single quotes when doing string comparison.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 3, 2020

@Raffo @seanmalloy
Now it should be fine to merge. Thx

@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo @njuettner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2020
@Raffo
Copy link
Contributor

Raffo commented Oct 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgrumboe, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 266e559 into kubernetes-sigs:master Oct 7, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 8, 2020

/label hacktoberfest-accepted

@k8s-ci-robot
Copy link
Contributor

@jgrumboe: The label(s) /label hacktoberfest-accepted cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label hacktoberfest-accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. hacktoberfest-accepted lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants