-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nektos/act #1802
Add support for nektos/act #1802
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
@vinny-sabatini could you please review |
@jgrumboe I haven't used nektos/act myself, so I don't really have an opinion on that, but I do have a question: given that in CI we basically just run builds and tests, which are cross platform and can be natively run locally, what is the benefit of being able to run those locally? |
@Raffo It gives you the possibility to test the usage of github actions before committing and waiting for failed or successful CI runs. And it is convenient for me to just run "act" and the CI pipeline kicksoff like after git push. |
@jgrumboe "it's convenient" is good enough for me. I will approve once you get a LGTM. One thing I don't understand: why is there no check for actions in this PR? |
We need to figure this out before it can be merged. Other recent pull requests have the GH actions running. Does this change somehow prevent/break the GH actions? |
Found the error: invalid syntax |
/hold |
/unhold The if: expression needs single quotes when doing string comparison. |
@Raffo @seanmalloy |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgrumboe, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label hacktoberfest-accepted |
@jgrumboe: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This PR adds support for nektos/act to run github actions locally.
Checklist