Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infoblox skip zones not matching a given view #1805

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Infoblox skip zones not matching a given view #1805

merged 3 commits into from
Oct 15, 2020

Conversation

jgrumboe
Copy link
Contributor

@jgrumboe jgrumboe commented Oct 3, 2020 •
edited

Description

Just fetch zones matching a given view from Infoblox. This reduces the load on Infoblox and the resultset received.

Checklist

  • Unit tests updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2020
@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 5, 2020

@saileshgiri would you like to review this?

@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 5, 2020

/assign njuettner

@Raffo
Copy link
Contributor

Raffo commented Oct 9, 2020

Can you provide more information? What is a view in InfoBlox terminology? What would this solve? What if the view is set to "" (or whatever the default value is)?

@jgrumboe
Copy link
Contributor Author

jgrumboe commented Oct 9, 2020 •
edited

@Raffo
A view in Infoblox is similar to a view in bind/named. If there's no view given (default is "") the API will give back objects of all views.

In most onprem cases you run split DNS. This means each zone is managed twice in different views.
Therefore we also run two external-dns instances each of them managing zones/records in different views.

Thia change limits the Infoblox API responses to these views which makes sense.

njuettner
njuettner approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgrumboe, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 77f082f into kubernetes-sigs:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. hacktoberfest-accepted lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jgrumboe @Raffo @k8s-ci-robot @njuettner