Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First implementation for arm images #1815

Merged
merged 18 commits into from
Oct 15, 2020
Merged

First implementation for arm images #1815

merged 18 commits into from
Oct 15, 2020

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Oct 14, 2020 •
edited

First implementation of #1443 #1721

@Raffo
multiarch init
41c16bc 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
change
abbce93 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
codespaces
8d5874a 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
add amd64 arch
f9073d7
@Raffo
changes
3944c81 
Signed-off-by: GitHub <noreply@github.com>
@Raffo
test
c835709 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
changes
bfe68ae
@Raffo
ch-changes
b5e6e3c 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
do not install certs
b99c4bb 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
save
d42fd0b 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
try amd64
d3ba4e4 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
amd64
7997d7e 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
remove devcontainer
9821957 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
tests
5954fbe 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
changes
cd98bf4 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo Raffo added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
njuettner
njuettner approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Raffo and others added 3 commits October 15, 2020 10:16
@Raffo @njuettner
Update Makefile
e84f1c7 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Raffo @njuettner
Update Makefile
9a75be7 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Raffo @njuettner
Update Makefile
e5ad3c5 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Raffo
Copy link
Contributor Author

Raffo commented Oct 15, 2020

@njuettner nits accepted, not working from my editors made me do that 😅

njuettner
njuettner approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

let's go 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b23151c into master Oct 15, 2020
cgroschupp pushed a commit to cgroschupp/external-dns that referenced this pull request Mar 23, 2021
@Raffo @njuettner @cgroschupp
First implementation for arm images (kubernetes-sigs#1815