Add arm32v7 arch for images #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Closed
|
/lgtm Adding a hold so @njuettner can review. Please remove the hold when you are ready for merge. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Raffo, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Raffo
removed
the
do-not-merge/hold
xunholy
reviewed
Oct 23, 2020
| @@ -102,6 +102,9 @@ build.arm64v8: | |||
| build.amd64: | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o build/$(BINARY) $(BUILD_FLAGS) -ldflags "$(LDFLAGS)" . | |||
|
|
|||
| build.arm32v7: | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=arm go build -o build/$(BINARY) $(BUILD_FLAGS) -ldflags "$(LDFLAGS)" . | |||
There was a problem hiding this comment.
I'd also suggest adding GOARM=7 so it's explicit the variant that is supported here.
Otherwise nice work!
There was a problem hiding this comment.
Oh I didn't know about that! Would you mind reviewing #1842 ?
givanov
added a commit
to givanov/k8s-arm-images
that referenced
this pull request
Jan 22, 2021
…rs now kubernetes-sigs/external-dns#1838 Signed-off-by: Georgi Ivanov <georgi@ouzi.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @njuettner for 👍