-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm32v7 arch for images #1838
Conversation
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
/lgtm Adding a hold so @njuettner can review. Please remove the hold when you are ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Raffo, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -102,6 +102,9 @@ build.arm64v8: | |||
build.amd64: | |||
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o build/$(BINARY) $(BUILD_FLAGS) -ldflags "$(LDFLAGS)" . | |||
|
|||
build.arm32v7: | |||
CGO_ENABLED=0 GOOS=linux GOARCH=arm go build -o build/$(BINARY) $(BUILD_FLAGS) -ldflags "$(LDFLAGS)" . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also suggest adding GOARM=7 so it's explicit the variant that is supported here.
Otherwise nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know about that! Would you mind reviewing #1842 ?
…rs now kubernetes-sigs/external-dns#1838 Signed-off-by: Georgi Ivanov <georgi@ouzi.dev>
/cc @njuettner for 👍