Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1888

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Update README.md #1888

merged 1 commit into from
Dec 9, 2020

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Dec 8, 2020

Description

Fixes:

  • deprecated --replicas flag for kubectl run
  • deployment -> pod; kubectl run creates a pod

Fixes #1873

@bl-ue
Update README.md
366d189 
Fixes:
- deprecated `--replicas` flag for `kubectl run` 
- `deployment` -> `pod`; `kubectl run` creates a `pod`
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2020
@bl-ue
Copy link
Contributor Author

bl-ue commented Dec 8, 2020

/cc @seanmalloy

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2020
@bl-ue bl-ue mentioned this pull request Dec 8, 2020
Closed
@seanmalloy
Copy link
Member

/assign @Raffo @njuettner
/lgtm
/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
njuettner
njuettner approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl-ue, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7d033a7 into kubernetes-sigs:master Dec 9, 2020
@bl-ue bl-ue deleted the patch-1 branch December 9, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instructions for running locally in README are out of date
5 participants
@bl-ue @seanmalloy @k8s-ci-robot @njuettner @Raffo