Documentation on Route53 and Govcloud. #1918

vchan2002 · 2021-01-12T05:42:10Z

Description

This adds a section of documentation specific to changes needed to run in Govcloud.

Fixes #1917

Checklist

Unit tests updated
End user documentation updated

k8s-ci-robot · 2021-01-12T05:42:14Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-01-12T05:42:18Z

Welcome @vchan2002!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

vchan2002 · 2021-01-12T05:54:35Z

CLA should be signed....

…ing to make public facing r53 entries

szuecs · 2021-01-12T09:29:26Z

👍

seanmalloy · 2021-01-12T19:30:56Z

/lgtm
/assign @Raffo @njuettner

seanmalloy · 2021-01-12T19:31:23Z

/kind documentation

njuettner

some minor nits, but looks good 👍🏻 . Thank you much appreciated!

njuettner · 2021-01-12T09:48:59Z

docs/tutorials/aws.md

+- --txt-prefix={{ YOUR_PREFIX }}
+```
+
+* The 1st two changes are needed if you use Route 53 in Govcloud, which only supports private zones. There are also no cross account IAM whatsoever between Govcloud and Commerical AWS accounts.  If services and ingresses need to make Route 53 entries to an public zone in a commerical account, you will have set env variables of AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY with a key and secret to the commerical account that has the sufficient rights.


Suggested change

* The 1st two changes are needed if you use Route 53 in Govcloud, which only supports private zones. There are also no cross account IAM whatsoever between Govcloud and Commerical AWS accounts. If services and ingresses need to make Route 53 entries to an public zone in a commerical account, you will have set env variables of AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY with a key and secret to the commerical account that has the sufficient rights.

* The first two changes are needed if you use Route53 in Govcloud, which only supports private zones. There are also no cross account IAM whatsoever between Govcloud and commerical AWS accounts. If services and ingresses need to make Route 53 entries to an public zone in a commerical account, you will have set env variables of AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY with a key and secret to the commerical account that has the sufficient rights.

njuettner · 2021-01-13T08:50:32Z

docs/tutorials/aws.md

+  value: us-gov-west-1
+```
+
+* Route 53 in Govcloud does not allow aliases.  Therefore, container args must be set so that it uses CNAMES and a txt-prefix must be set to something.  Otherwise, it will try to create a TXT record with the same value than the CNAME itself, which is not allowed.


Suggested change

* Route 53 in Govcloud does not allow aliases. Therefore, container args must be set so that it uses CNAMES and a txt-prefix must be set to something. Otherwise, it will try to create a TXT record with the same value than the CNAME itself, which is not allowed.

* Route53 in Govcloud does not allow aliases. Therefore, container args must be set so that it uses CNAMES and a txt-prefix must be set to something. Otherwise, it will try to create a TXT record with the same value than the CNAME itself, which is not allowed.

njuettner · 2021-01-13T08:51:09Z

docs/tutorials/aws.md

@@ -414,6 +414,39 @@ You can configure Route53 to associate DNS records with healthchecks for automat

 Note: ExternalDNS does not support creating healthchecks, and assumes that `<health-check-id>` already exists.

+## Govcloud caveats
+
+Due to the special nature with how Route 53 runs in Govcloud, there are a few tweaks in the deployment settings.


Suggested change

Due to the special nature with how Route 53 runs in Govcloud, there are a few tweaks in the deployment settings.

Due to the special nature with how Route53 runs in Govcloud, there are a few tweaks in the deployment settings.

njuettner · 2021-01-13T08:51:34Z

docs/tutorials/aws.md

+
+Due to the special nature with how Route 53 runs in Govcloud, there are a few tweaks in the deployment settings.
+
+* An Environment variable with name of AWS_REGION set to either us-gov-west-1 or us-gov-east-1 is required.  Otherwise it tries to lookup a region that does not exist in govcloud and it errors out.


Suggested change

* An Environment variable with name of AWS_REGION set to either us-gov-west-1 or us-gov-east-1 is required. Otherwise it tries to lookup a region that does not exist in govcloud and it errors out.

* An Environment variable with name of AWS_REGION set to either us-gov-west-1 or us-gov-east-1 is required. Otherwise it tries to lookup a region that does not exist in Govcloud and it errors out.

seanmalloy · 2021-01-13T16:21:57Z

@njuettner please take a look when you have some time.

/lgtm

njuettner

/lgtm
/approve

👍🏻

k8s-ci-robot · 2021-01-13T17:03:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, vchan2002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vchan2002 added 3 commits January 11, 2021 21:33

added instructions for govcloud

8eaef45

added space

a4e469a

tweak

de93699

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 12, 2021

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 12, 2021

k8s-ci-robot requested review from njuettner and Raffo January 12, 2021 05:42

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2021

changed wording to prevent confusion of using R53 in govcloud vs need…

61ed6b6

…ing to make public facing r53 entries

k8s-ci-robot assigned njuettner, Raffo and seanmalloy Jan 12, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021

k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 12, 2021

njuettner requested changes Jan 13, 2021

View reviewed changes

small changes to get PR approved

8565d0f

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021

njuettner approved these changes Jan 13, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021

k8s-ci-robot merged commit 43d587f into kubernetes-sigs:master Jan 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documentation on Route53 and Govcloud. #1918

Documentation on Route53 and Govcloud. #1918

vchan2002 commented Jan 12, 2021

k8s-ci-robot commented Jan 12, 2021

k8s-ci-robot commented Jan 12, 2021

vchan2002 commented Jan 12, 2021

szuecs commented Jan 12, 2021

seanmalloy commented Jan 12, 2021

seanmalloy commented Jan 12, 2021

njuettner left a comment

njuettner Jan 12, 2021 •

edited

Loading

njuettner Jan 13, 2021

njuettner Jan 13, 2021

njuettner Jan 13, 2021

seanmalloy commented Jan 13, 2021

njuettner left a comment

k8s-ci-robot commented Jan 13, 2021

	* Route 53 in Govcloud does not allow aliases. Therefore, container args must be set so that it uses CNAMES and a txt-prefix must be set to something. Otherwise, it will try to create a TXT record with the same value than the CNAME itself, which is not allowed.
	* Route53 in Govcloud does not allow aliases. Therefore, container args must be set so that it uses CNAMES and a txt-prefix must be set to something. Otherwise, it will try to create a TXT record with the same value than the CNAME itself, which is not allowed.

	Due to the special nature with how Route 53 runs in Govcloud, there are a few tweaks in the deployment settings.
	Due to the special nature with how Route53 runs in Govcloud, there are a few tweaks in the deployment settings.


		Due to the special nature with how Route 53 runs in Govcloud, there are a few tweaks in the deployment settings.

		* An Environment variable with name of AWS_REGION set to either us-gov-west-1 or us-gov-east-1 is required. Otherwise it tries to lookup a region that does not exist in govcloud and it errors out.

Documentation on Route53 and Govcloud. #1918

Documentation on Route53 and Govcloud. #1918

Conversation

vchan2002 commented Jan 12, 2021

k8s-ci-robot commented Jan 12, 2021

k8s-ci-robot commented Jan 12, 2021

vchan2002 commented Jan 12, 2021

szuecs commented Jan 12, 2021

seanmalloy commented Jan 12, 2021

seanmalloy commented Jan 12, 2021

njuettner left a comment

Choose a reason for hiding this comment

njuettner Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

njuettner Jan 13, 2021

Choose a reason for hiding this comment

njuettner Jan 13, 2021

Choose a reason for hiding this comment

njuettner Jan 13, 2021

Choose a reason for hiding this comment

seanmalloy commented Jan 13, 2021

njuettner left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 13, 2021

njuettner Jan 12, 2021 •

edited

Loading