Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godaddy #1924

Merged
merged 26 commits into from
Feb 12, 2021
Merged

Godaddy #1924

merged 26 commits into from
Feb 12, 2021

Conversation

Fred78290
Copy link
Contributor

Description

Adds a provider for GoDaddy's DNS service, using their HTTP API.

This part of code has been fully tested with an app having an ingress

Checklist

  • Unit tests updated
  • End user documentation updated
  • Add tutorial on how to set this up
  • Remove all the logging stuff

@k8s-ci-robot
Copy link
Contributor

Welcome @Fred78290!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2021
@Fred78290
Copy link
Contributor Author

/assign @njuettner

njuettner
njuettner requested changes Jan 19, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm fine with it, only some nits. But if you could make it possible somehow I'd suggest using a sdk if possible. This might next improvements or adjustments in the future a bit easier 🙂 .

main.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
provider/godaddy/client.go Show resolved Hide resolved
Fred78290 and others added 6 commits January 19, 2021 14:30
@Fred78290 @njuettner
Update docs/tutorials/godaddy.md
bf6641d 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290 @njuettner
Update docs/tutorials/godaddy.md
85e048d 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290 @njuettner
Update docs/tutorials/godaddy.md
02acef6 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290 @njuettner
Update main.go
33e53ed 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290 @njuettner
Update pkg/apis/externaldns/types.go
6e3c8ef 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290 @njuettner
Update pkg/apis/externaldns/types.go
db648ac 
Co-authored-by: Nick Jüttner <nick@juni.io>
@Fred78290
Copy link
Contributor Author

In general I'm fine with it, only some nits. But if you could make it possible somehow I'd suggest using a sdk if possible. This might next improvements or adjustments in the future a bit easier slightly_smiling_face .

Strange, I'd already replied but I don't find it. There is any official GoDaddy API SDK supplied by GoDaddy in any language. Only individual implementation.

@Fred78290 Fred78290 closed this Jan 20, 2021
@Fred78290
Copy link
Contributor Author

Argg closed accidentaly :(

@Fred78290 Fred78290 reopened this Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2021
@nscriptdotgo
Copy link

Hello, is this still being worked on? my team could definitely leverage this functionality. thanks!

@Fred78290
Copy link
Contributor Author

Hello, I'm still waiting for review & approve step.

njuettner
njuettner approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey cool @Fred78290, sorry for the late response but you PR is not forgotten 😄 .
Thanks for addressing my comments, happy to merge it 🚀 .

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fred78290, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 38da5fd into kubernetes-sigs:master Feb 12, 2021
@seanmalloy seanmalloy mentioned this pull request Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fred78290 @k8s-ci-robot @nscriptdotgo @njuettner