Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Scaleway DNS API to v2beta1 #1938

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Jan 28, 2021

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Description

Bump the API version of the Scaleway DNS to v2beta1

Checklist

  • [x ] Unit tests updated

Waiting for #1859 to rebase on it
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2021
@Sh4d1 Sh4d1 force-pushed the bump_scw_dns branch 2 times, most recently from 3112a85 to 79b9a08 Compare January 28, 2021 08:32
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jan 28, 2021

/assign @Raffo
still need to test that it still works as expected, will cancel the hold once good

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jan 28, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 28, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jan 28, 2021

Everyhting looks good to me 😄

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
Copy link
Member Author

Sh4d1 commented Feb 24, 2021

@Raffo did you find some time to look at this? 😄

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021
@Raffo
Copy link
Contributor

Raffo commented Mar 2, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 057cae0 into kubernetes-sigs:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants