Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC3645 support for secure updates with GSS-TSIG #1951

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add RFC3645 support for secure updates with GSS-TSIG #1951

merged 1 commit into from
Feb 12, 2021

Conversation

scottd018
Copy link
Contributor

Description

This commit will allow for the use of GSS-TSIG updates to an RFC2136 DNS provider. Most commonly, this is implemented by way of "Secure DNS Updates" in Microsoft Active Directory environments.

  • Add in inputs to take in kerberos username/password and whether or not to use gss-tsig for rfc2136 provider
  • Update documentation to outline how to use a kerberos configuration as a configmap for external-dns
  • Use new packages from "github.com/bodgit/tsig/gss" to perform negotiation with kerberos provider for the DNS update using gss-tsig

Fixes #1520

Checklist

  • [ x ] Unit tests updated
  • [ x ] End user documentation updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2021
@scottd018 scottd018 mentioned this pull request Feb 4, 2021
Closed
@scottd018
Copy link
Contributor Author

Old MR at #1629

@scottd018 scottd018 changed the title Fixes #1520, Add RFC3645 support for secure updates with GSS-TSIG Add RFC3645 support for secure updates with GSS-TSIG Feb 5, 2021
@scottd018 scottd018 force-pushed the feature-add_rfc3645_support_fixup branch from f54e0c7 to 1e4c1e2 Compare February 5, 2021 14:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 5, 2021
@scottd018
Copy link
Contributor Author

/assign @njuettner

njuettner
njuettner approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, scottd018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 455467c into kubernetes-sigs:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RFC3645 Support
3 participants
@scottd018 @k8s-ci-robot @njuettner