Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move from dynectsoap to dynsoap #1985

Merged
merged 5 commits into from
May 2, 2021
Merged

feat: move from dynectsoap to dynsoap #1985

merged 5 commits into from
May 2, 2021

Conversation

PG2000
Copy link
Contributor

@PG2000 PG2000 commented Mar 2, 2021

Description

This change removes the use of dynectsoap library from dyn provider since it is not licensed or actively being maintained and is missing the usage of a proxy.
It introduces a similar library https://github.com/PG2000/dynsoap which uses more generated code and has a MIT License

Fixes #1787

Checklist

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @PG2000!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 3, 2021
@PG2000
Copy link
Contributor Author

PG2000 commented Mar 8, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 8, 2021
@PG2000
Copy link
Contributor Author

PG2000 commented Mar 9, 2021

/assign @njuettner

@Raffo
Copy link
Contributor

Raffo commented Mar 10, 2021

@PG2000 to prevent other problems with the maintenance of the library, given that most seems to be generated, can't we just add all the files to ExternalDNS transferring its ownership and remove completely the external dependency?

@PG2000
Copy link
Contributor Author

PG2000 commented Mar 10, 2021

@PG2000 to prevent other problems with the maintenance of the library, given that most seems to be generated, can't we just add all the files to ExternalDNS transferring its ownership and remove completely the external dependency?

@Raffo
absolutely. The generated file (it implements all soap functions) is about 1,2 MB in size. If thats ok i will prepare it

@Raffo
Copy link
Contributor

Raffo commented Mar 10, 2021

@PG2000 Yes it's not a problem.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2021
@PG2000
Copy link
Contributor Author

PG2000 commented Mar 12, 2021

@Raffo i transferred all files to this project.

How can i exclude the generated code from code coverage report?

@PG2000
Copy link
Contributor Author

PG2000 commented Mar 23, 2021

@Raffo can i help somehow?

@seanmalloy
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 13, 2021
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PG2000 please review the method comments and align to the go convention as I mentioned in my comment. After you do that we can totally merge this PR!

provider/dyn/soap/client.go Outdated Show resolved Hide resolved
@PG2000
Copy link
Contributor Author

PG2000 commented Apr 19, 2021

@Raffo done!

@PG2000 PG2000 requested a review from Raffo April 19, 2021 18:28
@Raffo
Copy link
Contributor

Raffo commented May 2, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PG2000, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 399fc75 into kubernetes-sigs:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the use of dynectsoap library from dyn provider since it is not licensed or actively being maintained
5 participants