Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.16 #2003

Merged
merged 7 commits into from
Mar 31, 2021
Merged

Update to Go 1.16 #2003

merged 7 commits into from
Mar 31, 2021

Conversation

eXeDK
Copy link
Contributor

@eXeDK eXeDK commented Mar 9, 2021

Description

Updates the go version to 1.16 along with the documentation.

Checklist

  • [n/a] Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2021
@Raffo
Copy link
Contributor

Raffo commented Mar 10, 2021

We want to wait to at least 1.16.1 to do any upgrade.

@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 10, 2021

Should I update this PR when 1.16.1 is available?

@Raffo
Copy link
Contributor

Raffo commented Mar 10, 2021

@eXeDK sounds good. I don't expect problems, but testing of an imagine built with 1.16.1 would be good as well.

@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 10, 2021

Sure thing. I'll run the test suite and try building the docker image beforehand.

@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 11, 2021

This has now been bumped to 1.16.1.

@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 12, 2021

This has now been bumped to 1.16.2.

@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 16, 2021

/honk

@k8s-ci-robot
Copy link
Contributor

@eXeDK:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njuettner
njuettner requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'd like to avoid the patch version, we had a chat about this in the past and we agreed avoiding it.

I'm happy to merge your PR 🚀

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile.mini Outdated Show resolved Hide resolved
docs/contributing/getting-started.md Outdated Show resolved Hide resolved
eXeDK and others added 4 commits March 30, 2021 11:10
@eXeDK @njuettner
Update .github/workflows/ci.yml
5800f6d 
Co-authored-by: Nick Jüttner <nick@juni.io>
@eXeDK @njuettner
Update Dockerfile
deb805c 
Co-authored-by: Nick Jüttner <nick@juni.io>
@eXeDK @njuettner
Update Dockerfile.mini
f67242e 
Co-authored-by: Nick Jüttner <nick@juni.io>
@eXeDK @njuettner
Update docs/contributing/getting-started.md
67ef48f 
Co-authored-by: Nick Jüttner <nick@juni.io>
@eXeDK
Copy link
Contributor Author

eXeDK commented Mar 30, 2021

Fair enough. I understood you differently I guess. You should be good to go now. Thanks for the suggestions - quick and easy!

@eXeDK eXeDK requested a review from njuettner March 30, 2021 10:27
njuettner
njuettner approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eXeDK, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit fbbc2b9 into kubernetes-sigs:master Mar 31, 2021
@eXeDK eXeDK deleted the bump-go-1-16 branch March 31, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eXeDK @Raffo @k8s-ci-robot @njuettner