Add the ability to configure k8s event rate limit #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the minimum delay between 2 kubernetes events handling is hard-coded to 5s. This may cause higher synchronization rates and higher DNS provider API calls when handling an important number of kubernetes events at once. Give the opportunity to configure this delay so service owners can define the acceptable thresholds on their side
k8s-ci-robot
added
cncf-cla: yes
|
/assign @Raffo |
Raffo
reviewed
Mar 18, 2021
tjamet
force-pushed
the
feat/flag-min-sync
branch
from
be7c231
to
d0ccc9b
Compare
k8s-ci-robot
added
size/M
@Raffo thanks for the suggestion, I updated the wording |
Co-authored-by: Raffaele Di Fazio <raffo@github.com>
tjamet
force-pushed
the
feat/flag-min-sync
branch
from
d0ccc9b
to
43f9f56
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, tjamet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minimum delay between 2 kubernetes events handling is
hard-coded to 5s.
This may cause higher synchronization rates and higher DNS provider API
calls when handling an important number of kubernetes events at once.
Give the opportunity to configure this delay so service owners can
define the acceptable thresholds on their side
Contributes to fixing #1293
Checklist