Fix CNAME update for hetzner provider

[packi]

Description

The name conditioning was applied twice which caused CNAMES to be suffixed by a double '.'. This leads to the value being rejected by the Hetzner API with error-code 422 which is not being checked at the moment.

We should probably check the error-code to be 0 so this doesn't fail silently, I can do that in another PR.

Fixes #1869

Checklist

• Unit tests updated
• End user documentation updated

/assign @21h

[k8s-ci-robot]

@packi: GitHub didn't allow me to assign the following users: 21h.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Description

The name conditioning was applied twice which caused CNAMES to be suffixed by a double '.'. This leads to the value being rejected by the Hetzner API with error-code 422 which is not being checked at the moment.

We should probably check the error-code to be 0 so this doesn't fail silently, I can do that in another PR.

Fixes #1869

Checklist

• Unit tests updated
• End user documentation updated

/assign @21h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @packi!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[njuettner]

/cc @21h

[k8s-ci-robot]

@njuettner: GitHub didn't allow me to request PR reviews from the following users: 21h.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @21h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[21h]

/cc @21h

yes, i have seen it from another pr. i'll review as fast as i can.

[seanmalloy]

/kind bug

[21h]

@seanmalloy it can be merged

[njuettner]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, packi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment