Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Azure provider "Failed to extract" log message to debug #2020

Merged

Conversation

bittrance
Copy link
Contributor

The only thing present in the external-dns when running with the Azure provider is:

time="2021-03-19T21:11:37Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:12:37Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:13:38Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:14:38Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:15:39Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:16:39Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:17:40Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."
time="2021-03-19T21:18:47Z" level=error msg="Failed to extract targets for 'example.com' with type 'NS'."

It is not really an error to have an NS record in one's zone. Nor is external-dns expected to act on it. Looking at the Azure private provider

log.Debugf("Failed to extract targets for '%s' with type '%s'.", name, recordType)
, this message is debug, which seems more reasonable. This PR changes the Azure public provider to match.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @bittrance!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2021
When running the Azure provider at default log level, this messages
is 1/min and is the only messge in the log. Debug seems more
reasonable and matches what Azure Private provider.
@Raffo
Copy link
Contributor

Raffo commented Mar 22, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittrance, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ca57a5 into kubernetes-sigs:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants