-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scaleway): drop support for organization ID as it's not needed #2021
Conversation
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
/assign @njuettner |
@njuettner could we merge this before next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind updating the docs? If the organization ID is not needed anymore, I'm happy to merge it 🙂
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Updated! 😄 |
@njuettner good? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Sh4d1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Patrik Cyvoct patrik@ptrk.io
Description
This PR drop the need to specify the Scaleway Organization ID as it's not needed.
I'll update the documentation once the new release is cut.
Checklist