Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scaleway): drop support for organization ID as it's not needed #2021

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Mar 22, 2021

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Description

This PR drop the need to specify the Scaleway Organization ID as it's not needed.
I'll update the documentation once the new release is cut.

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Mar 22, 2021

/assign @njuettner

@Sh4d1
Copy link
Member Author

Sh4d1 commented Mar 30, 2021

@njuettner could we merge this before next release?

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind updating the docs? If the organization ID is not needed anymore, I'm happy to merge it 🙂

Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1
Copy link
Member Author

Sh4d1 commented Mar 31, 2021

Updated! 😄

@Sh4d1
Copy link
Member Author

Sh4d1 commented Apr 7, 2021

@njuettner good? 😄

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@njuettner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 43d29f8 into kubernetes-sigs:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants