Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'bluecat' as possible option to the provider flag #2035

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

brross
Copy link
Contributor

@brross brross commented Apr 1, 2021

'bluecat' was missing from the enumerated list of possible values for the provider flag

Description
Add bluecat as a valid provider option to the provider flag.

Although bluecat had previously been added to the descriptive help text for the provider flag it was not included in the enumerated list of acceptable values.

Fixes #2034

Checklist

  • [n/a] Unit tests updated
  • [n/a] End user documentation updated

'bluecat' was missing from the enumerated list of possible values for the provider flag
@k8s-ci-robot
Copy link
Contributor

Welcome @brross!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2021
@brross
Copy link
Contributor Author

brross commented Apr 1, 2021

/cc @seanmalloy @vinny-sabatini

@seanmalloy
Copy link
Member

@brross thanks for fixing this!

/lgtm
/kind bug
/assign @njuettner @Raffo

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021
@Raffo
Copy link
Contributor

Raffo commented Apr 1, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brross, Raffo, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8327c7c into kubernetes-sigs:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/bluecat: bluecat missing from provider EnumVar in types.go
5 participants