bluecat: allow setting TTL on cname and host records #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TTL can now be set for CName and Host records for the Bluecat provider. You can not set the TTL of TXT records because that is not currently implemented in the Bluecat Gateway
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinny-sabatini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
Want to test this a little more and see if there are any other tests worth writing before marking it ready for review, but I think this is close. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @seanmalloy |
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TTL can now be set for CName and Host records for the Bluecat
provider. You can not set the TTL of TXT records because that is not
currently implemented in the Bluecat Gateway
Fixes #2022
Checklist