bluecat: support getting credentials from environment variables #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for getting BlueCat API credentials from environment variables BLUECAT_USERNAME and BLUECAT_PASSWORD. Providing credentails using the BlueCat JSON configuration file is still supported. Credentials from environment variables take precedence over credentials provided in the JSON configuration file. Using environment variables avoids having to store credentials as k8s secrets.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@vinny-sabatini I'll do separate PR to update the end user documentation. /assign @vinny-sabatini |
k8s-ci-robot
added
the
kind/feature
|
FYI ... @sanbornick and @seegeekrow |
vinny-sabatini
approved these changes
May 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seanmalloy, vinny-sabatini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for getting BlueCat API credentials from environment
variables BLUECAT_USERNAME and BLUECAT_PASSWORD. Providing credentails
using the BlueCat JSON configuration file is still supported.
Credentials from environment variables take precedence over credentials
provided in the JSON configuration file.
Using environment variables avoids having to store credentials as k8s
secrets.
Checklist