Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix managed-record-types option #2078

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

k0da
Copy link
Contributor

@k0da k0da commented May 13, 2021

Use config option instead of passing just A and CNAME

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

Description

Fixes #2081

Checklist

  • Unit tests updated
  • End user documentation updated

Use config option instead of passing just A and CNAME

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2021
@k0da
Copy link
Contributor Author

k0da commented May 13, 2021

/assign @Raffo

@k0da
Copy link
Contributor Author

k0da commented May 26, 2021

ping

@k0da
Copy link
Contributor Author

k0da commented Aug 4, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2021
@Raffo
Copy link
Contributor

Raffo commented Aug 4, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k0da, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 41ea66b into kubernetes-sigs:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

managed-record-types have no effect
3 participants