-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure.md #2096
Update azure.md #2096
Conversation
updated version of external-dns, added notes for MSI permissions and which roles can be used, fixed mounting of config-file-secret
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @DOliana! |
I have signed the CNCF CLA about 16 hours ago, but for some reason it is not working... Where can I see hints on what went wrong to open a ticket? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DOliana, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DOliana What was the key |
@darkn3rd This was more than a year ago... If I remember correctly it was just to have a proper name for reference. Nothing special to the environment. |
Description
I tried the tutorial today and ran into some issues. So I decided to post an update to the tutorial.
What I did:
(If I missed anything I am happy to contribute)