Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure.md #2096

Merged
merged 1 commit into from
May 26, 2021
Merged

Update azure.md #2096

merged 1 commit into from
May 26, 2021

Conversation

DOliana
Copy link
Contributor

@DOliana DOliana commented May 20, 2021

Description

I tried the tutorial today and ran into some issues. So I decided to post an update to the tutorial.

What I did:

  • updated version of the external-dns image to 0.8.0
  • added notes for MSI permissions since I found that using the cluster-msi did not work since the service tried to use the agentpool msi
  • and which roles can be used since a less privileged role than contributor can be used
  • fixed mounting of config-file-secret, since the container started with the error that it could not find the config file azure.json

(If I missed anything I am happy to contribute)

updated version of external-dns, added notes for MSI permissions and which roles can be used, fixed mounting of config-file-secret
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @DOliana!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2021
@DOliana
Copy link
Contributor Author

DOliana commented May 21, 2021

I have signed the CNCF CLA about 16 hours ago, but for some reason it is not working... Where can I see hints on what went wrong to open a ticket?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 21, 2021
@Raffo
Copy link
Contributor

Raffo commented May 24, 2021

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@Raffo
Copy link
Contributor

Raffo commented May 26, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DOliana, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4c5f9ac into kubernetes-sigs:master May 26, 2021
@darkn3rd
Copy link
Contributor

darkn3rd commented May 4, 2022

@DOliana What was the key externaldns-config.json added? This broke the instructions as previous steps create a secret with the key azure.json. Was externaldns-config.json something unique to your environment?

@DOliana
Copy link
Contributor Author

DOliana commented May 5, 2022

@darkn3rd This was more than a year ago... If I remember correctly it was just to have a proper name for reference. Nothing special to the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants