Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluecat: add delete functionality #2144

Merged
merged 1 commit into from
Jul 8, 2021
Merged

bluecat: add delete functionality #2144

merged 1 commit into from
Jul 8, 2021

Conversation

jaideepbellani
Copy link
Contributor

@jaideepbellani jaideepbellani commented Jun 24, 2021 •
edited by seanmalloy
Loading

Description

Added the ability to delete records for the Bluecat provider

Fixes #2143

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jaideepbellani!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2021
@seanmalloy
Copy link
Member

/assign

@seanmalloy
Copy link
Member

/assgin @vinny-sabatini

@seanmalloy
Copy link
Member

/assign @vinny-sabatini

@seanmalloy
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021
@jaideepbellani jaideepbellani marked this pull request as ready for review July 1, 2021 19:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2021
seanmalloy
seanmalloy requested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@seanmalloy seanmalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added some small suggestions inline.

provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat_test.go Outdated Show resolved Hide resolved
sgreene570
sgreene570 reviewed Jul 6, 2021
View reviewed changes
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
seanmalloy
seanmalloy requested changes Jul 7, 2021
View reviewed changes
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@seanmalloy
Copy link
Member

@vinny-sabatini this change looks good to me. Please add your approval if you think this looks good.

Adding a hold so commits can be squashed before merging.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
vinny-sabatini
vinny-sabatini suggested changes Jul 7, 2021
View reviewed changes
provider/bluecat/bluecat.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@seanmalloy
Copy link
Member

seanmalloy commented Jul 7, 2021 •
edited
Loading

@vinny-sabatini the requested changes have been made. Please review one more time. Thanks!

vinny-sabatini
vinny-sabatini reviewed Jul 8, 2021
View reviewed changes
Copy link
Contributor

@vinny-sabatini vinny-sabatini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job @jaideepbellani !
Please cleanup your commit history and we can get this merged

@vinny-sabatini
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@seanmalloy
Copy link
Member

@jaideepbellani please squash commits and we will merge it. Thanks!

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@seanmalloy
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 8, 2021
@seanmalloy seanmalloy self-requested a review July 8, 2021 16:35
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaideepbellani, seanmalloy, vinny-sabatini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c3a28ec into kubernetes-sigs:master Jul 8, 2021
@seanmalloy seanmalloy deleted the bluecat-delete branch July 8, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgreene570 sgreene570 sgreene570 left review comments

@seanmalloy seanmalloy seanmalloy approved these changes

@vinny-sabatini vinny-sabatini vinny-sabatini approved these changes

Assignees

@seanmalloy seanmalloy

@vinny-sabatini vinny-sabatini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to delete record using Bluecat provider
5 participants
@jaideepbellani @k8s-ci-robot @seanmalloy @vinny-sabatini @sgreene570