Clean up OpenShift Route source implementation

[sgreene570]

Description

This PR contains the following commits:

source: Clean up OpenShift Route source

source/ocproute.go:

Add/clean up godocs and general in-line comments.

Change routeapi named import to routev1.
Update routev1 calling sites accordingly.

Signed-off-by: Stephen Greene sgreene@redhat.com

source: Add ocproute source unit tests

source/ocproute_test.go:

New file for source/ocproute.go unit tests.

Inspired by the service source unit tests,
this commit adds basic unit tests to verify
basic functionality of the OCP route source.

Signed-off-by: Stephen Greene sgreene@redhat.com

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @sgreene570!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[sgreene570]

/cc @Miciah @seanmalloy @jgrumboe @ahmedwaleedmalik

[k8s-ci-robot]

@sgreene570: GitHub didn't allow me to request PR reviews from the following users: Miciah, jgrumboe, ahmedwaleedmalik.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Miciah @seanmalloy @jgrumboe @ahmedwaleedmalik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jgrumboe]

Thanks, Stephen, looks nice!
Can't test because I don't own an Openshift cluster anymore.

[sgreene570]

Thanks, Stephen, looks nice!
Can't test because I don't own an Openshift cluster anymore.

Actually, I just dropped my small functional change in this PR since I realized it was not needed, so this PR should have no affect on the source implementation and shouldn't require any manual testing on OpenShift.

The new unit tests should run just fine in the unit test CI job. 😀
@jgrumboe, could you help me get the proper approvals to trigger CI on this PR, by chance?

[seanmalloy]

/cc @seanmalloy @vinny-sabatini

[njuettner]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment