-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement external provider for EfficientIP SOLIDserver #2238
Implement external provider for EfficientIP SOLIDserver #2238
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @EIP-Laurent! |
158b9c5
to
2f190d4
Compare
Rebase is done |
How can i try it ? |
Hello, To try it you have to :
For the official release I do not know. Best regards. |
When i tried i got an issue : I can't find where it get "vmdev-ct-fb11" as solidserver name |
Hello, Ok I will take a look and come back to you, for the vmdev-ct-fb11 it was a dummy name that have been used to generate the Go API used by the provider. My first impression is it looks like the Go API used to requests the SDS does match the one we had expect since the commit a4a4561 |
REBASE Signed-off-by: EIP-Laurent <lg@efficientip.com>
978a3dd
to
f80425b
Compare
@EIP-Laurent any news ? |
@EIP-Laurent any news ? |
Hi, I have just corrected the conflict and I am waiting for the reviews. |
@mecmus, @njuettner or @seanmalloy can you review again ? |
Reviews will be so great please |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EIP-Laurent The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello, Any chance someone can review again to unlock this topic ? Thanks in advance. |
We don't add providers anymore. They should soon be able to use the new plugin interface. See the plug-in provider pr. |
Sorry, but initial PR was submitted about 1.5 years ago. Considering the efforts put into implementing this specific provider based on what was available back at this time, I hope you will reconsider this answer. Kind regards. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, Any news on this? Is there a way to use externalDNS with EfficientIP solidserver (without RFC2136)? |
Hello, |
@mloiseleur: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: EIP-Laurent lg@efficientip.com
Description
This PR implements the provider interface for EfficientIP's SOLIDserver DNS
Checklist