-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: fix merging of endpoints - same hostname different set-identifier #2259
service: fix merging of endpoints - same hostname different set-identifier #2259
Conversation
Welcome @mper0003! |
/assign @njuettner |
@Raffo @njuettner ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, it makes sense.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mper0003, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Updates
source/service.go
to also check the endpoint'sSetIdentifier
before merging endpoints with the samehostname
. Currently, services with the same hostname annotation but different set identifiers get merged, so not all the DNS records specified using annotations get created, i.e. when specifying weighted Route53 DNS records.Fixes #2245
Checklist