Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CNAME record when multiple router canonical name are defined in Route Status. #2400

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix CNAME record when multiple router canonical name are defined in Route Status. #2400

merged 1 commit into from
Nov 19, 2021

Commits on Nov 3, 2021

  1. In OCP when you have multiple ingress controllers the route's status … 

    …Ingress object get populated with multiple router canonical names. So in this case, the external dns tries to add multiple CNAME records for same host in the same hosted zone which is a violation of RFC 1912  and therefore is rejected by standards-compliant DNS services.

This feature adds a router field to the OCP Route Source so that a user can add an ingress controller name in flag --ocp-router-name which will be used to pick up the respective routerCanonicalHostname from Route's Status Ingress Object.

Signed-off-by: Miheer Salunke <miheer.salunke@gmail.com>
    @miheer
    miheer committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ab8a620 View commit details
    Browse the repository at this point in the history