-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ingress spec in given examples #2414
Conversation
### Description A previous PR (kubernetes-sigs#1978) updated the ingress API version but the spec needed an update as well. I tested this locally by applying the yaml with a valid DNS hostname. ### Checklist - [ ] Unit tests updated - [x] End user documentation updated
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @gregwhorley! |
/check-cla |
LGTM, but looks like https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/kube-ingress-aws.md & https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/nginx-ingress.md could use the same kind of TLC (assuming those tutorials are still relevant / up to date)? 😁 |
Sure I can update those too |
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570 I updated the docs you linked above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gregwhorley, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gregwhorley @Raffo I think the Did you discuss this? If there is nothing against it I can open a PR 😉 |
@froblesmartin Ah good catch, I forgot to remove the annotations. Feel free to open a PR 😄 |
Description
A previous PR (#1978) updated the ingress API version but the spec needed an update as well. I tested this locally by applying the yaml with a valid DNS hostname.
Fixes #ISSUE
Checklist