Adds support for user specified Service annotations

[rk295]

Description

Adds the ability to specify optional annotations to be applied to the Service resource within Kubernetes.

Fixes #2431

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Welcome @rk295!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[stevehipwell]

@rk295 thank for this PR. It looks like you need to update the chart version, I'd suggest a minor bump for added functionality, and the chart annotations to carry your changes before the CI will be able to pass.

[rk295]

Thanks @stevehipwell I've bumped it to 1.6.0 - is that what you meant? And added my changes into the changes section.

[stevehipwell]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rk295, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stevehipwell]

/ok-to-test

[stevehipwell]

@Raffo it appears that I can't enable workflows for first time contributors?

[Raffo]

@stevehipwell I think we would need repo admin to the repo and I don't manage that 😞

[rk295]

@stevehipwell I know you had already approved, but this morning I realised I had not updated the README.md - just pushed a small commit documenting this new value. Hope that is ok!

[Raffo]

Probably this should be

Annotations to add to the service.    

[rk295]

lol, slow morning is slow. Fixed now!

[stevehipwell]

@stevehipwell I think we would need repo admin to the repo and I don't manage that 😞

As long as it's the expected behaviour that's fine.

[Raffo]

As long as it's the expected behaviour that's fine.

I think it is. I think most of the kubernetes related projects use the internal google CI and we've been a bit operating independently and went with GitHub Actions which has advantages and disadvantages. I don't mind being pinged to approve the run by clicking on the button. It's a bit silly, but it's something we had to implement at GitHub (disclaimer: I'm an employee) to fight abuse.

[stevehipwell]

It's a bit silly, but it's something we had to implement at GitHub (disclaimer: I'm an employee) to fight abuse.

I think it's a good idea, maybe Prow could make it so once someone has been approved in one org repo they're fixed in others, unless this is already the behaviour?

[Raffo]

@stevehipwell the default behavior is that after the first contribution you get automatic approval. I think it's an okay tradeoff like that.

[stevehipwell]

@Raffo I've approved this so do you want to add the LGTM?

[Raffo]

/lgtm

[stevehipwell]

@Raffo I seem to have broken the release action with my previous PR, let me take a look and I'll see what's happened.

[stevehipwell]

@rk295 this should have now been released.