Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): update chart process #2433

Merged
merged 1 commit into from
Nov 12, 2021
Merged

feat(chart): update chart process #2433

merged 1 commit into from
Nov 12, 2021

Conversation

stevehipwell
Copy link
Contributor

Description

This PR achieves the following:

  • Only run chart CI on this repo and not on forks
  • Allow chart validation to run without changing the version in Chart.yaml
  • Allow chart changes to be merged to master without releasing the chart
  • Document the chart release process
  • Document contributing to the chart

Checklist

  • Unit tests updated
  • End user documentation updated

@stevehipwell
feat(chart): update chart process
c525935 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2021
@stevehipwell
Copy link
Contributor Author

This PR is based off kubernetes-sigs/metrics-server#877.

/assign @Raffo

@Raffo
Copy link
Contributor

Raffo commented Nov 12, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit abb67e7 into kubernetes-sigs:master Nov 12, 2021
@stevehipwell stevehipwell deleted the chart-process branch November 12, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevehipwell @Raffo @k8s-ci-robot