Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chart): fix actions reop filter #2434

Merged
merged 1 commit into from
Nov 12, 2021
Merged

chore(chart): fix actions reop filter #2434

merged 1 commit into from
Nov 12, 2021

Conversation

stevehipwell
Copy link
Contributor

Description

This PR fixes the chart GH actions repo filter.

See https://github.com/kubernetes-sigs/external-dns/actions/runs/1452859429 for the error.

Checklist

  • Unit tests updated
  • End user documentation updated

@stevehipwell
chore(chart): fix actions reop filter
bf8a33d 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2021
@stevehipwell
Copy link
Contributor Author

/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2021
Raffo
Raffo approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaml coding is hard 😅

@Raffo
Copy link
Contributor

Raffo commented Nov 12, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8040b22 into kubernetes-sigs:master Nov 12, 2021
@stevehipwell stevehipwell deleted the fix-chart-actions-repo-filter branch November 12, 2021 12:07
@stevehipwell
Copy link
Contributor Author

Yaml coding is hard 😅

@Raffo I copied the pattern from my Metrics Server PR, but I know that I should have used ' over " for the filter so I must have been having a bad day both times!

Could you manually run the release chart workflow? If it works as expected I'll have to open a PR over at Metrics Server to fix the same issue.

@Raffo
Copy link
Contributor

Raffo commented Nov 12, 2021

It doesn't look like it works or I am doing something wrong..

@stevehipwell
Copy link
Contributor Author

It looks like you can't start a new workflow, just re-run existing ones. I'll open a PR to trigger the build again.

@stevehipwell
Copy link
Contributor Author

Please see #2437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo approved these changes

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevehipwell @Raffo @k8s-ci-robot