-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudflare provider - Removed incorrect log message #2471
Cloudflare provider - Removed incorrect log message #2471
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @NicklasWallgren! |
|
02ed833
to
627bed2
Compare
|
627bed2
to
3cca377
Compare
I signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense, no matter the logic, this is just printing a log and don’t nothing else, so it’s hardly useful.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NicklasWallgren, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't understand the reasoning behind this log message, we had to disable the logging inside the external-dns container due to the extensive logging.
The
endpoint.Targets
can contain multiple targets, which should be fine.We could probably remove this logging, or refactor the logic around
newCloudFlareChange
insideApplyChanges
.