Kops Compatibility #1: Set RecordType at source #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sethpollack
commented
Jun 27, 2017
sethpollack
commented
- Use constants for RecordType's
- Set RecordType in the sources
- Remove ALIAS type (This is only used to determine if we should create an AliasTarget for the AWS provider and should be internal to the AWS provider. Also when we add multiple-target support we will group records by DNSName/RecordType, so we need to convert the RecordType back to a CNAME in order to properly compare current vs desired. Additionally AliasTarget only supports single targets, so when we switch to multiple-targets we will need to determine based on the target count as well.)
k8s-ci-robot
added
the
cncf-cla: yes
|
lgtm |
sethpollack
force-pushed
the
record_types
branch
from
404f87e
to
67a2e09
Compare
|
@sethpollack could you please rebase this PR on master, and then we can get it merged :) |
sethpollack
force-pushed
the
record_types
branch
from
c1a7ae7
to
e68cb8e
Compare
|
@sethpollack Thanks a lot! |
|
@sethpollack Just went through this PR again and noticed again how great it is, thanks 😃 |
|
Thanks |
ffledgling
pushed a commit
to ffledgling/external-dns
that referenced
this pull request
Jan 18, 2018
* set RecordType at source * add comments for linting
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
* Add code pattern test to ensure glog is not used in tests * Use t.Log instead of glog in tests * Search for the actual function and not for the import when checking code patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.