Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infoblox] Granular level of logging #2502

Merged
merged 4 commits into from
Jan 12, 2022

Conversation

BobVanB
Copy link
Contributor

@BobVanB BobVanB commented Jan 3, 2022

This adds logging per target type to give better insight in the inner workings of the records being created in Infoblox.

In preference of #1521 (ordered):

  1. [Infoblox] Disable always changed by defaulting TTL to 0 #2500
  2. [Infoblox] Update fqdn to zone and add record filter #2496
  3. [Infoblox] Granular level of logging #2502
  4. [Infoblox] Support multiple targets in a endpoint #2501

Checklist

  • Unit tests updated (not needed)
  • End user documentation updated (not needed)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 3, 2022
@BobVanB
Copy link
Contributor Author

BobVanB commented Jan 3, 2022

/assign @njuettner

@njuettner
Copy link
Member

@BobVanB there's a linting issue, can you check please?

provider/infoblox/infoblox.go:666: File is not `gofmt`-ed with `-s` (gofmt)
								_, err = p.client.DeleteObject(record.Ref)
make: *** [Makefile:51: go-lint] Error 1
Error: Process completed with exit code 2.

@BobVanB
Copy link
Contributor Author

BobVanB commented Jan 5, 2022

@njuettner I turned autoformat off. The indenting gave me alot of changes that i didn't want to see during development.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2022
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobVanB, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit d521d5d into kubernetes-sigs:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants