Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for overriding managed-record-types #2539

Merged

Conversation

jkremser
Copy link
Contributor

Description

Very little change that adds the test case that verifies that overriding the config works also for managed-record-types (env vars and cli params). The test file works as a good source of documentation for newcomers and it helped me to realise what's the env var name of the cli param and vice-versa. The EXTERNAL_DNS_MANAGED_RECORD_TYPES was missing here though so I was puzzled what to use..

Checklist

  • Unit tests updated
  • End user documentation updated (very minor change for this)

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jkremser!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2022
@jkremser
Copy link
Contributor Author

/assign @njuettner

@Raffo
Copy link
Contributor

Raffo commented Jan 26, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkremser, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 64ac4e3 into kubernetes-sigs:master Jan 26, 2022
@jkremser jkremser deleted the test-override-record-types branch January 26, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants