Add missing test for overriding managed-record-types #2539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very little change that adds the test case that verifies that overriding the config works also for
managed-record-types
(env vars and cli params). The test file works as a good source of documentation for newcomers and it helped me to realise what's the env var name of the cli param and vice-versa. TheEXTERNAL_DNS_MANAGED_RECORD_TYPES
was missing here though so I was puzzled what to use..Checklist
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com