-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove an obsolete TODO comment #2582
Remove an obsolete TODO comment #2582
Conversation
This comment belonged to a switch-statement that has since been removed, but it was forgotten to remove the corresponding comment.
|
Welcome @NobodysNightmare! |
/kind cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, NobodysNightmare The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a very small PR.
While trying to understand how AAAA records are handled, I stumbled upon this comment, because I believed that it refers to the if statement below:
However, it turns out that the comment is unrelated. It was introduced in b0f437a and references a switch statement that has been removed (I guess the ownership system is in place now).