OCI Provider: fix private zones match to add/update/validate recods for DNS. #2628

vickydev90 · 2022-03-01T18:24:38Z

Description

This PR fix issue to list/match private zones in OCI if user specify arg --oci-zone-scope-filter .

Fixes #2615

Before PR

time="" level=warning msg="No zones in compartment \"ocid1.compartment.oc1..\" match domain filters [xyz.com]"

After PR

Record getting updated as needed and validated.

time="" level=info msg="All records are already up to date"

Checklist

Unit tests updated - updated
End user documentation updated - updated

…loud.google.com/go-0.97.0 build(deps): bump cloud.google.com/go from 0.94.1 to 0.97.0

Bumps [github.com/Azure/azure-sdk-for-go](https://github.com/Azure/azure-sdk-for-go) from 46.3.0+incompatible to 46.4.0+incompatible. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/CHANGELOG.md) - [Commits](Azure/azure-sdk-for-go@v46.3.0...v46.4.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ithub.com/Azure/azure-sdk-for-go-46.4.0incompatible build(deps): bump github.com/Azure/azure-sdk-for-go from 46.3.0+incompatible to 46.4.0+incompatible

Bumps [github.com/akamai/AkamaiOPEN-edgegrid-golang](https://github.com/akamai/AkamaiOPEN-edgegrid-golang) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/akamai/AkamaiOPEN-edgegrid-golang/releases) - [Changelog](https://github.com/akamai/AkamaiOPEN-edgegrid-golang/blob/master/CHANGELOG.md) - [Commits](akamai/AkamaiOPEN-edgegrid-golang@v1.0.0...v1.1.1) --- updated-dependencies: - dependency-name: github.com/akamai/AkamaiOPEN-edgegrid-golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ithub.com/akamai/AkamaiOPEN-edgegrid-golang-1.1.1 build(deps): bump github.com/akamai/AkamaiOPEN-edgegrid-golang from 1.0.0 to 1.1.1

…are already managed by external dns

In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) Other decent change was that most methods exported by the library now require `context.Context` to be passed in. Was rather trivial to get up. cloudflare/cloudflare-go#595 Signed-off-by: Devon Mizelle <devon.mizelle@onepeloton.com>

Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest) from 0.11.20 to 0.11.21. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/v0.11.20...autorest/v0.11.21) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/vultr/govultr/v2](https://github.com/vultr/govultr) from 2.8.1 to 2.9.0. - [Release notes](https://github.com/vultr/govultr/releases) - [Changelog](https://github.com/vultr/govultr/blob/master/CHANGELOG.md) - [Commits](vultr/govultr@v2.8.1...v2.9.0) --- updated-dependencies: - dependency-name: github.com/vultr/govultr/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.38 to 1.40.53. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.38...v1.40.53) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…sion Remove version from readme

…ithub.com/aws/aws-sdk-go-1.40.53 build(deps): bump github.com/aws/aws-sdk-go from 1.40.38 to 1.40.53

remove unused parameters in aws change submit method

Signed-off-by: GitHub <noreply@github.com>

Update clusterrole in kustomize

Bump appVersion in chart

Add registry as a flag for helm chart

kustomize: Grant watch nodes instead of get

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.53 to 1.42.52. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.53...v1.42.52) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ithub.com/aws/aws-sdk-go-1.42.52 Bump github.com/aws/aws-sdk-go from 1.40.53 to 1.42.52

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.22.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.22.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…8s.io/apimachinery-0.23.3 Bump k8s.io/apimachinery from 0.22.2 to 0.23.3

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.1 to 0.23.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.23.1...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/transip/gotransip/v6](https://github.com/transip/gotransip) from 6.6.2 to 6.14.0. - [Release notes](https://github.com/transip/gotransip/releases) - [Commits](transip/gotransip@v6.6.2...v6.14.0) --- updated-dependencies: - dependency-name: github.com/transip/gotransip/v6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/maxatome/go-testdeep](https://github.com/maxatome/go-testdeep) from 1.10.1 to 1.11.0. - [Release notes](https://github.com/maxatome/go-testdeep/releases) - [Commits](maxatome/go-testdeep@v1.10.1...v1.11.0) --- updated-dependencies: - dependency-name: github.com/maxatome/go-testdeep dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/Azure/azure-sdk-for-go](https://github.com/Azure/azure-sdk-for-go) from 61.4.0+incompatible to 61.5.0+incompatible. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/CHANGELOG.md) - [Commits](Azure/azure-sdk-for-go@v61.4.0...v61.5.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/vultr/govultr/v2](https://github.com/vultr/govultr) from 2.9.0 to 2.14.1. - [Release notes](https://github.com/vultr/govultr/releases) - [Changelog](https://github.com/vultr/govultr/blob/master/CHANGELOG.md) - [Commits](vultr/govultr@v2.9.0...v2.14.1) --- updated-dependencies: - dependency-name: github.com/vultr/govultr/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ithub.com/Azure/azure-sdk-for-go-61.5.0incompatible Bump github.com/Azure/azure-sdk-for-go from 61.4.0+incompatible to 61.5.0+incompatible

…ithub.com/maxatome/go-testdeep-1.11.0 Bump github.com/maxatome/go-testdeep from 1.10.1 to 1.11.0

…ithub.com/transip/gotransip/v6-6.14.0 Bump github.com/transip/gotransip/v6 from 6.6.2 to 6.14.0

…ithub.com/vultr/govultr/v2-2.14.1 Bump github.com/vultr/govultr/v2 from 2.9.0 to 2.14.1

…8s.io/api-0.23.3 Bump k8s.io/api from 0.23.1 to 0.23.3

…nted-valid-options Helm chart: fix documented valid options for logLevel

linux-foundation-easycla · 2022-03-01T18:24:41Z

✅ Kubernetes Prow Robot (e782bf3, d9baed0, ea8d29b, daae6c7, c3c2c2b, 9054b19, 5186c97, 297b69f, c1706f0, e718e14, 9660aef, b201732, 4d6459c, d66941e, 06464c8, dd9110f, 82364a0, 9121995, aa9e83f, 322e76b, e8b4356, 32a0b4f, 8245ada, 735a457, c575635, 463af9d, c56b0a7, 489ec20, 4f3922a, 5c7f046, 0fb535e, 564cdcf, cf3f8e3, 77d7354, aefc180, 351358b, d9952fe, 7141ac9, 47d1e41, baf9112, abdda3b, 91e98ff, 2671aa4, 5eae6a3, afa6e99, e93d940, f1c0387, 2460605, 1623817, e86b12d, 949fb3d, 4d0ae04, ee676e8, da3f496, ef87d93, 0c2db52, df22053, 23698a9, 67393a6, cbf9e3b, d514a93, 59f25e0, 3a05578, dcbab0a, 993a08e, b85f18d, ba35029, ddbf96b, f683531, a43c6a1, 3d89d1d, 8d2e00e, 1591a6e, c64ac0e, 5b19fd2, f2b9d54, 6295f44, 32242ab, 512078b, 9753488, 42becbf, eb60279, b3d9586, 17aebff, f2d7912, a019dfe, 54a52ef, 8d96ce6, ed46cc4, 6c139d6)
✅ dependabot[bot] (10781d0, 92dc770, e7ea140, dadb5ab, 5d0db35, cc683c3, fd063f4, c103e0b, 3885714, fbc2bed, ea2012c, 9675a20, c175bad, 7fc56f9, 9cf2d79, 0a3425e, b479909, 63cee7e, 6956581, cfeaa5a, 6f460e2, 3dc2ad3, c4ecd81, d0987da, e20d8e3)
✅ Christian Groschupp (314557a)
✅ Pavel Tumik (dd87895, 66f2636, 952189e)
✅ Devon Mizelle (1d7d747, 1b2e3f4, baabb85, 2aedead)
✅ Raffaele Di Fazio (c537992, 223aa64, 99b45aa, 186d63e, 0c5e8b6, 6de08ad, e940f45, 2f46404, fa36dab, bcc9f27, 010849a, 64f2846, 8bc6b9d, 4308664, e0cf5a5, 1bcd4ba, cd74496, 58f0e38, 7e0f06a, b85a803, 62b60e6, 8a100ba, c916225, 6eee389, f017b36, 0d00464, ce893e4, 3056af3, c65cc25, c970dfa)
✅ Stuart P. Bentley (365d37c)
✅ Maxime Brunet (e47760f)
✅ Nick Jüttner (8b96cf0, 3eacc9d, a7674d9, a002a1e, 0eb0c38, 4ab61ad, 2290dad, 56d991e, 592a98d, 295805e, e56d913, 2107502, 243a98d, dce236d, 593732c)
✅ Ari Becker (3084cbd)
✅ Pascal Bourdier (de53c52)
✅ Arjun Naik (484ab21)
✅ Brett Polivka (1bf7556)
✅ Andrey Lebedev (2a0e95b, c45e9c5, e8a67a2)
✅ Steve Hipwell (987d926, 2a8e720, 40f5047, 7ea0bcc, d38d353, 8941f3a)
✅ Alexandre Gaudreault (b2b8146, ce2cef9, d217be8)
✅ adityask2 (8011d1f, e634da7)
✅ Andrew Haines (b933769, 26367fa, 2461d19)
✅ Alastair Firth (7eb489c)
✅ jdgri (2299805)
✅ Robin Kearney (059db3a, dca8b83, 334724e, d242616, e44937b)
✅ George Buckerfield (b39ca93)
✅ Dinar Valeev (fd373c8)
✅ Artem Voronin (73a3245, a981e96, 252a089, 36830dd, 094845d)
✅ Sean Malloy (f775312, faebdef, b649fc6)
✅ Michael Grüner (cd66dd8)
✅ Anthony Stanton (8f9eb20)
✅ Aaron Crickenberger (cdd58b7)
✅ Kyle Michel (f11ee73)
✅ NicklasWallgren (9748809)
✅ beastob (6e0d9f0)
✅ Alexander Berger (4c7b7ed)
✅ Alexander Shangin (b5908b6)
✅ cyril-corbon (5937082)
✅ Bob van Bokkem (5eb3cdb, b93ee1c, 200750c, 17d77fb)
✅ Rick Henry (cf15e43, 0eedc32, 249d5e9, fbbead9, 7637a56, a7c8f98, bdcdc15, 53bec62)
✅ Joshua Hoblitt (4463ab9)
✅ Milind Chawre (f9ad504)
✅ Jirka Kremser (c7da695)
✅ Matthew Warman (ffcf3fb)
✅ Jan Sandbrink (4f9811b)
✅ Vinny Sabatini (05145a3)
✅ Andrew Plummer (48bbc5b)

❌ - Jonathan Romahn The commit (da4f45b ,d6495001f634194588ce3a988020178973919794 ,4b3085e464ca7e070d6157587a68fb9fa78b4c54) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
❌ - svonliebenstein The commit (e1b66d2) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
❌ - Miheer Salunke The commit (113f6db) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
❌ - Greg Whorley The commit (403ac71 ,e35c385c1064466ca4487d3d47f4f4a858bcb8ab ,3e734518e0f23146d6fa285eec146f6a00832574 ,f7388f4f999beb8dbb2f69ebff91b6f674634a78 ,3753509d17ae9dca8c6c2967ea9915a2ccf02143 ,f11210fca24e580f24ed33d0f9be2a2fd648d4f2 ,7a0bd9b369d4d8f191c111808584132a9b600d32 ,e0bbd7b1161c57cc7675c68c8c9ace47bbdef732) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
❌ The commit (8032bc3) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot · 2022-03-01T18:24:45Z

Welcome @vickydev90!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-03-01T18:25:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vickydev90
To complete the pull request process, please assign raffo after the PR has been reviewed.
You can assign the PR to them by writing /assign @raffo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2022-03-02T10:49:12Z

@vickydev90: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mschmidt291 · 2022-03-08T12:06:14Z

@vickydev90 Any plans on fixing the PR? We also experience this issue.
Thanks in advance

k8s-ci-robot and others added 30 commits September 30, 2021 01:36

Merge pull request #2336 from kubernetes-sigs/dependabot/go_modules/c…

e782bf3

…loud.google.com/go-0.97.0 build(deps): bump cloud.google.com/go from 0.94.1 to 0.97.0

Merge pull request #2333 from kubernetes-sigs/dependabot/go_modules/g…

d9baed0

…ithub.com/Azure/azure-sdk-for-go-46.4.0incompatible build(deps): bump github.com/Azure/azure-sdk-for-go from 46.3.0+incompatible to 46.4.0+incompatible

Merge pull request #2337 from kubernetes-sigs/dependabot/go_modules/g…

ea8d29b

…ithub.com/akamai/AkamaiOPEN-edgegrid-golang-1.1.1 build(deps): bump github.com/akamai/AkamaiOPEN-edgegrid-golang from 1.0.0 to 1.1.1

infoblox: also create a ptr entry

314557a

infoblox: add test for findReserseZone

dd87895

fix some issues with ptr support and remove ttl references

66f2636

make sure that external-dns will create PTR records for records that …

952189e

…are already managed by external dns

ListZonesContext no longer takes paginationOptions

1b2e3f4

go.sum update

baabb85

remove version from readme

c537992

Merge pull request #2342 from kubernetes-sigs/raffo/remove-readme-ver…

223aa64

…sion Remove version from readme

Merge pull request #2341 from kubernetes-sigs/dependabot/go_modules/g…

daae6c7

…ithub.com/aws/aws-sdk-go-1.40.53 build(deps): bump github.com/aws/aws-sdk-go from 1.40.38 to 1.40.53

Merge pull request #2318 from tariq1890/aws-refactor

c3c2c2b

remove unused parameters in aws change submit method

Bump appVersion in chart

365d37c

update clusterrole in kustomize

99b45aa

fix indentation

186d63e

bump version

0c5e8b6

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #2347 from kubernetes-sigs/raffo/update-v0.10-role

9054b19

Update clusterrole in kustomize

Merge pull request #2343 from stuartpb/patch-1

5186c97

Bump appVersion in chart

kustomize: Grant watch nodes instead of get

e47760f

Add registry as a flag for helm chart

8b96cf0

bump chart version

3eacc9d

Merge pull request #2352 from kubernetes-sigs/helm-registry-flag

297b69f

Add registry as a flag for helm chart

Merge pull request #2351 from maxbrunet/hotfix/kustomize/watch-nodes

c1706f0

kustomize: Grant watch nodes instead of get

dependabot bot and others added 17 commits February 13, 2022 13:42

Merge pull request #2590 from kubernetes-sigs/dependabot/go_modules/g…

243a98d

…ithub.com/aws/aws-sdk-go-1.42.52 Bump github.com/aws/aws-sdk-go from 1.40.53 to 1.42.52

Merge pull request #2544 from kubernetes-sigs/dependabot/go_modules/k…

dce236d

…8s.io/apimachinery-0.23.3 Bump k8s.io/apimachinery from 0.22.2 to 0.23.3

Merge pull request #2596 from kubernetes-sigs/dependabot/go_modules/g…

a019dfe

…ithub.com/Azure/azure-sdk-for-go-61.5.0incompatible Bump github.com/Azure/azure-sdk-for-go from 61.4.0+incompatible to 61.5.0+incompatible

Merge pull request #2595 from kubernetes-sigs/dependabot/go_modules/g…

54a52ef

…ithub.com/maxatome/go-testdeep-1.11.0 Bump github.com/maxatome/go-testdeep from 1.10.1 to 1.11.0

Merge pull request #2594 from kubernetes-sigs/dependabot/go_modules/g…

593732c

…ithub.com/transip/gotransip/v6-6.14.0 Bump github.com/transip/gotransip/v6 from 6.6.2 to 6.14.0

Merge pull request #2597 from kubernetes-sigs/dependabot/go_modules/g…

8d96ce6

…ithub.com/vultr/govultr/v2-2.14.1 Bump github.com/vultr/govultr/v2 from 2.9.0 to 2.14.1

Merge pull request #2593 from kubernetes-sigs/dependabot/go_modules/k…

ed46cc4

…8s.io/api-0.23.3 Bump k8s.io/api from 0.23.1 to 0.23.3

Helm chart: fix documented valid options for logLevel

48bbc5b

Merge pull request #2626 from plumdog/helm-chart-log-level-fix-docume…

6c139d6

…nted-valid-options Helm chart: fix documented valid options for logLevel

config to specify zone filter for OCI

8032bc3

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 1, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2022

k8s-ci-robot requested review from Raffo and seanmalloy March 1, 2022 18:25

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2022

vickydev90 closed this Mar 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCI Provider: fix private zones match to add/update/validate recods for DNS. #2628

OCI Provider: fix private zones match to add/update/validate recods for DNS. #2628

vickydev90 commented Mar 1, 2022

linux-foundation-easycla bot commented Mar 1, 2022 •

edited

Loading

k8s-ci-robot commented Mar 1, 2022

k8s-ci-robot commented Mar 1, 2022

k8s-ci-robot commented Mar 2, 2022

mschmidt291 commented Mar 8, 2022

OCI Provider: fix private zones match to add/update/validate recods for DNS. #2628

OCI Provider: fix private zones match to add/update/validate recods for DNS. #2628

Conversation

vickydev90 commented Mar 1, 2022

linux-foundation-easycla bot commented Mar 1, 2022 • edited Loading

k8s-ci-robot commented Mar 1, 2022

k8s-ci-robot commented Mar 1, 2022

k8s-ci-robot commented Mar 2, 2022

mschmidt291 commented Mar 8, 2022

linux-foundation-easycla bot commented Mar 1, 2022 •

edited

Loading